search

TimeLineAnnotator / desktop

A GUI for graphical analysis and annotation of video and audio files.
https://tilia-app.com
Creative Commons Attribution Share Alike 4.0 International
8 stars 2 forks source link

Fix Inspector again #122

Closed azfoo closed 4 weeks ago

azfoo commented 1 month ago

closes #119

FelipeDefensor commented 1 month ago

Will take a look at the changes once I finish working on the PDF timeline. In the meantime, I found this:

https://github.com/FelipeDefensor/TiLiA/assets/87732202/3848b1c5-ad38-4953-962d-d0155201712a

There's an empty space below the PDF inspector if we first open the inspector while it is selected.

azfoo commented 1 month ago

There's an empty space below the PDF inspector if we first open the inspector while it is selected.

I can't tell for sure, but it could be a branch thing. There is a notable gap after the last item on the table even on the latest update but I don't see anything that could be causing it.

FelipeDefensor commented 4 weeks ago

There's an empty space below the PDF inspector if we first open the inspector while it is selected.

I can't tell for sure, but it could be a branch thing. There is a notable gap after the last item on the table even on the latest update but I don't see anything that could be causing it.

It's a branch thing, sorry. I was (obviously) using the pdf timeline branch when I made the video. I do just get the small gap when selecting beat on beat timelines on this branch.

FelipeDefensor commented 4 weeks ago

@azfoo this is approved. I have been rebasing and merging your PRs myself after approval, but I like the idea of the author doing that better. It gives a last chance to make any changes that might have occured to her between the review request and the approval. Let's start doing that with this PR, ok?

Don't forget that we are on the rebase team, so choose "Rebase and merge" instead of "Create a merge commit".

azfoo commented 4 weeks ago

I think I did that right... Will do the rebasing and merging myself in the future after your review approval.