TimeLineAnnotator / desktop

A GUI for graphical analysis and annotation of video and audio files.
https://tilia-app.com
Creative Commons Attribution Share Alike 4.0 International
8 stars 2 forks source link

Deleting beat timelines with many beats is taking a long time #129

Closed FelipeDefensor closed 4 weeks ago

FelipeDefensor commented 4 weeks ago

Judging by the "logs" it seems the is_first_in_measure attribute is being recalculated for every remaining beat when one beat gets deleted, so this is currently O(n^2). We should be able to avoid that easily by setting a flag to prevent recalculation or, more easily, by deleting in reverse chronological order, as recalculation in only triggered for beats after the deleted one.

FelipeDefensor commented 4 weeks ago

Fixed by 6a6e393.