search

TimeLineAnnotator / desktop

A GUI for graphical analysis and annotation of video and audio files.
https://tilia-app.com
Creative Commons Attribution Share Alike 4.0 International
8 stars 2 forks source link

Add player features #132

Closed azfoo closed 8 hours ago

azfoo commented 3 weeks ago

closes #123, #135

azfoo commented 3 weeks ago

mostly done, except for adding icons to the loop and volume toggle - will do so in the coming week. would also like to add another button to reset the playback speed to 1.0x, if you don't think that is too much clutter.

FelipeDefensor commented 3 weeks ago

mostly done, except for adding icons to the loop and volume toggle - will do so in the coming week. would also like to add another button to reset the playback speed to 1.0x, if you don't think that is too much clutter.

Hooray! I think the reset button might be too much clutter, as the user is probably two clicks away from resetting anyways. Let's keep that on stand by and see if we miss it.

FelipeDefensor commented 3 weeks ago

It's worth noting that playback rate control and looping YouTube streams (without downloading them) is something that no other software offers, as far as I know. This combo is very useful for transcription.

FelipeDefensor commented 2 weeks ago

I think some comments got duplicated from the last review.

azfoo commented 9 hours ago

On a side note: How much do you really like that blur effect around the slider line? As I said wrt the previous loop highlight, I think it clashes with the clear edges of the rest of the app. I would like to change that, in the future.

Mostly because there isn't a way of adding an outline to a line item, so this was a hacky way around it. At some future point, qGraphicsLineItem could be subclassed and reimplemented with an actual outline.

FelipeDefensor commented 9 hours ago

On a side note: How much do you really like that blur effect around the slider line? As I said wrt the previous loop highlight, I think it clashes with the clear edges of the rest of the app. I would like to change that, in the future.

Mostly because there isn't a way of adding an outline to a line item, so this was a hacky way around it. At some future point, qGraphicsLineItem could be subclassed and reimplemented with an actual outline.

Yes, we could use that class in other places. I think the easiest way to do it is to have a slighthly bigger line with the color of the outline behind the "main" one. Let's worry about that later, though.