Closed azfoo closed 2 days ago
It's mostly for you to have a play around and see what you think. Vertical scrolling might not be the most useful feature but horizontal scrolling should be handy considering most of the data in the app is along the x-axis. Standardised wheel events might be more intuitive for the first-time user, and zooming is still only two clicks away either by the shortcut or the view buttons. A fun side effect of this implementation is that trackpad dragging now works!
I'm still getting the extra vertical scrolling. Maybe some Qt default?
https://github.com/TimeLineAnnotator/desktop/assets/87732202/0dcdcc3e-25a4-47ed-8c2d-32020389c386
I like the Shift+Wheel for horizontal scrolling!
I'm still not sure about the horizontal zooming, but good point about it still being available farily easily. I was thinking that eventually we need to add one of those percentage and slider interfaces for zooming that most document viewers have ...
... so what about we postpone changing the sortcuts until then?
that should fix it - though it might have accidentally fixed something that was meant for the next version too.
that should fix it - though it might have accidentally fixed something that was meant for the next version too.
It does fix it. I suggest we comment out (or something equivalent) the parts of the code that change the horizontal scrolling to Shift+Wheel and merge this. When the time comes we can just uncomment and get back the new behavior.
not quite commented out, just stored in a function that is never called. switching over will just involve changing/replacing function names.
not quite commented out, just stored in a function that is never called. switching over will just involve changing/replacing function names.
That's even better. Feel free to merge.
closes #141 Fixes accidental scroll on zoom Added horizontal and vertical zooming through modifiers