search

TimeLineAnnotator / desktop

A GUI for graphical analysis and annotation of video and audio files.
https://tilia-app.com
Creative Commons Attribution Share Alike 4.0 International
8 stars 2 forks source link

refactor subscriptions from __init__ #90

Closed azfoo closed 2 months ago

azfoo commented 3 months ago

Resolves #91

Moved all listen and serve calls to _setup_subscriptions.

azfoo commented 3 months ago

I like what the GET/POST model is trying to get at! It's a naming system that points to an existing idea - a good reference for people to consider when trying to understand the code.

FelipeDefensor commented 3 months ago

Ok, so let's stick with the name requests for now. Then, you need to rename the _setup_subscriptions methods to _setup_requests and we're done with this PR.

FelipeDefensor commented 2 months ago

Ok. So I'm still away from my coding setup, I will wait until I get that back to make the actual review, but everything seems fine, apart from the fact that the commit history is a little confusing. I can fix that later, no problem.

FelipeDefensor commented 2 months ago

So, I finally got around to reviewing this. Sorry for the huge delay. Everything seems fine. The only thing I did was squashing the four rename commits into a single one.