TimeToogo / tunshell

Remote shell into ephemeral environments 🐚 🦀
https://tunshell.com
MIT License
767 stars 56 forks source link

feat: add build target for Apple M1 chip #35

Closed vandot closed 2 years ago

vandot commented 2 years ago

Tunshell client doesn't have support for a new Apple M1 chip, this PR should enable it aarch64-apple-darwin target is listed here

TimeToogo commented 2 years ago

Hi @vandot,

Thanks for submitting this PR. It is missing the necessary modifications to the install scripts (https://github.com/TimeToogo/tunshell/tree/master/scripts) to select and download the right tunshell binary for this new target.

vandot commented 2 years ago

Sure, updated the PR, below listed the arch output for all scripts

NodeJS

> os.platform()
'darwin'
> os.arch()
'arm64'

PHP

php > $os = php_uname('s');
php > $arch = php_uname('m');
php > echo $os;
Darwin
php > echo $arch;
arm64

Python

>>> import platform
>>> system = platform.system()
>>> arch = platform.machine()
>>> print(system)
Darwin
>>> print(arch)
arm64

BASH

$ echo $(uname -s):$(uname -m):$(uname -v):$(uname -a)
Darwin:arm64:Darwin Kernel Version 21.3.0: Wed Jan 5 21:37:58 PST 2022; root:xnu-8019.80.24~20/RELEASE_ARM64_T6000:Darwin ip-192-168-68-100.eu-central-1.compute.internal 21.3.0 Darwin Kernel Version 21.3.0: Wed Jan 5 21:37:58 PST 2022; root:xnu-8019.80.24~20/RELEASE_ARM64_T6000 arm64
TimeToogo commented 2 years ago

Great work! Thanks @vandot

vandot commented 2 years ago

@TimeToogo tested client on Apple M1 and it works 🙌 Thank you for the quick merge 👍