search

TimeViewers / signalworks

MIT License
3 stars 2 forks source link

add create partition obj #19

Closed tuanad121 closed 5 years ago

tuanad121 commented 5 years ago

add a function to create partition obj from list of (start time, end time, label)

tuanad121 commented 5 years ago

will do it soon :D

j9ac9k commented 5 years ago

wait, why are you bumping version on this branch?

...and why is the bump the minor version, and not the patch version?

tuanad121 commented 5 years ago

wait, why are you bumping version on this branch?

...and why is the bump the minor version, and not the patch version?

I built the release from the branch so we can use new functions of Partition in Fred. The version on Pypi is 0.2.0 but I'm not sure why the version of branch is still < 0.2.0. So I did minor bump instead of several patch bump to update the version.

j9ac9k commented 5 years ago

This isn't made explicit in the README (I should make it so); but the version numbers (major, minor, patch) do have definitions for what a version change entails, you can read about semantic versioning here: https://semver.org/

The needs of a downstream tool (such as Fred), should not cause us to generate premature releases here with signalworks. If we need to tap into a non-standard branch for a downstream tool, we can do so just as we currently do with pyqtgraph.

We should likely implement a change where only the CI deploys code to pypi, with a git version tag being committed to the master branch.