Closed zepfred closed 2 days ago
@triceo I created a new pull request because the branch was renamed to run the tests correctly. Your comments from #102 have been addressed.
@Christopher-Chianelli @triceo, do we all agree to use the summarize
as a method?
def assert_score_analysis_summary(score_analysis: ScoreAnalysis):
summary = score_analysis.summarize()
...
match = score_analysis.constraint_analyses[0]
match_summary = match.summarize()
...
@Christopher-Chianelli My rationale for summarize
is that this isn't actually an accessor for a property, it is not a constant - in that case, arguably summary
would be correct. But summarize
is a method that computes a result when it is called, which I think warrants the different name. IMO it has nothing to do with Python or Java.
Are you telling me that in Python, they don't actually make a distinction between methods and properties, even though they clearly have those constructs?
I give up. This is not worth the time we already spent on it.
@zepfred, please, change it back to summary
and make it a property. I'm sorry for this.
I was deleting one of my comments and accidentally deleted yours, @Christopher-Chianelli. My apologies, was not intentional.
No worries @triceo
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
93.4% Coverage on New Code
0.0% Duplication on New Code
@zepfred Please state clearly when a PR depends on another PR; in particular, this PR shouldn't have been merged before https://github.com/TimefoldAI/timefold-solver/pull/923
@zepfred Please state clearly when a PR depends on another PR; in particular, this PR shouldn't have been merged before TimefoldAI/timefold-solver#923
Understood!
This pull request adds a summary logic to the
ScoreAnalysis
andConstraintAnalysis
classes. Additionally, it synchronizes the API of the Python_score_analysis.py
with the Java classes.