chore: improve reliability metric - Githubissues

TimefoldAI / timefold-solver-python

Timefold Solver is an AI constraint solver for Python to optimize the Vehicle Routing Problem, Employee Rostering, Maintenance Scheduling, Task Assignment, School Timetabling, Cloud Optimization, Conference Scheduling, Job Shop Scheduling, Bin Packing and many more planning problems.

https://timefold.ai

Apache License 2.0

36 stars 3 forks source link

chore: improve reliability metric #71

Closed Christopher-Chianelli closed 3 months ago

Christopher-Chianelli commented 3 months ago

Don't use disjoint types in test assertions
Rename equal to pythonEquals in numeric types to avoid any potential confusion with Object.equals

zepfred commented 3 months ago

The daemon thread PR will solve the failing test, right?

Christopher-Chianelli commented 3 months ago

The daemon thread PR will solve the failing test, right?

Look like still flaky even with the daemon PR; I will add a @pytest.mark.xfail until the root cause of the flakiness is eventually found

sonarcloud[bot] commented 3 months ago

Quality Gate failed

Failed conditions
60.0% Coverage on New Code (required ≥ 75%)
25.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud