search

TimelordUK / jspurefix

native typescript FIX engine
MIT License
58 stars 27 forks source link

1.2.0 fixup #20

Closed NiklasZ closed 2 years ago

NiklasZ commented 3 years ago

Hi there,

I was writing an acceptor with the library and noticed a few bugs to fix:

  1. The session did not initialise with the input config's sequence numbers correctly (https://github.com/TimelordUK/jspurefix/commit/f911579fd7d546998c8d7ac419715ab156069324).
  2. The checkSeqNo() method will trigger an endless resend loop if it notices a message gap on a ResendRequest. This is because it will then respond with a ResendRequest of its own, which can trigger another ResendRequest from the counterparty and so on. I have tweaked it to process Logon and ResendRequest before it sends its own ResendRequest. (https://github.com/TimelordUK/jspurefix/pull/20/commits/ed18daea7fcbcbdb09e06fdce35db8320a1f8eb5)
TimelordUK commented 2 years ago

thanks very much for your support of this fix engine, really appreciate fixes. Will release soon.

NiklasZ commented 2 years ago

No problem. As a heads up: I may be pushing another PR with some more fixes in a few days.