search

TimelordUK / jspurefix

native typescript FIX engine
MIT License
58 stars 27 forks source link

Removing not used dependencies #40

Closed hmvs closed 2 years ago

hmvs commented 2 years ago

It seems that the following dependencies are not used in the project, so I removed them.

TimelordUK commented 2 years ago

Thanks for update.

hmvs commented 2 years ago

Thank you for the library!

I know it is not part of this PR. However, there are no "discussions" enabled on GitHub for this project. So I will ask you here.

  1. I can see that tests are broken by your yesterday's commit. Is it fine?
  2. I guess I can further optimize dependencies (for instance mathjs is used only once for formatting number), is it something that you will accept as PR? Also, I would like to remove express as a dependency.
  3. I can see there are a lot of functions that use Promises and some of them are hard to read (at least for me), will you accept PR that will use async-await instead? Or it is the way?
TimelordUK commented 2 years ago

Started discussion on this project.

I always hoped it would bring more people onto node for FIX applications and welcome updates and improvements. So yes async style code is welcome I’d only ask we ensure performance is more or less maintained.