search

TimelordUK / jspurefix

native typescript FIX engine
MIT License
60 stars 28 forks source link

BeginString Tag 8 should be 8=FIX.4.x rather than 8=FIX4.x etc #50

Closed NikolaosWakem closed 11 months ago

NikolaosWakem commented 2 years ago

There should be an extra . in the BeginString in the examples etc

e.g. 8=FIX.4.x rather than 8=FIX4.x etc

otherwise lots of headaches ;-)

TimelordUK commented 1 year ago

thanks for raising this. I have partially fixed this with config and some tests - some of tests will be quite time consuming to fix as we are checking exact buffer positions which would all fail.

TimelordUK commented 11 months ago

closing this now fixed thanks for raising issue