search

TimelordUK / jspurefix

native typescript FIX engine
MIT License
61 stars 28 forks source link

Pass config options and logger factory via session launcher #55

Closed ChrisiPK closed 1 year ago

ChrisiPK commented 2 years ago

While integrating jspurefix in an app, I realized there is no way to pass a custom logger. Also, there is no way to pass session options without storing them in a file.

This PR addresses both issues. It keeps the existing functionality intact, so it does not break backwards compatibility.

There is a slight change in the public API: The type of SessionLauncher.initiatorconfig and SessionLauncher.acceptorConfig is now ISessionDescription. Before, it was string.

Please let me know what you think. I am happy to improve on this PR, if required.

TimelordUK commented 1 year ago

This looks a great piece of work thanks a lot for using the library and helping to improve it. I will check all testing etc looks good and pull very shortly.

ChrisiPK commented 1 year ago

Thanks, happy to hear that you like it.

I made one more small changed and corrected the overload definitions as this is closer to the actual implementation. It doesn't change the functionality, though.

TimelordUK commented 1 year ago

greaat work thanks so much for improving and using the library