TimelordUK
commented
1 year ago Yes this looks like an issue. Will there be a PR for it ? I will take a look shortly but yes we should not try and send messages on transport failed state. Sent from my iPhoneOn 22 Nov 2022, at 08:02, Peter Cicman @.***> wrote: When the remote closes the socket during a running session, the following kicks in (FixSession): rx.on('done', () => { logger.info('rx done received') this.done() })
This will trigger session logout, which in turn will attempt to send Logout through the closed connection and fails with: error: unexpected state - transport failed? = WaitingLogoutConfirm : Error: unexpected state - transport failed? = WaitingLogoutConfirm. Should not this state transition (after socket close) instead prevent sending any further messages and terminate instead so the session can be recovered and reconnected? This also causes problems with message persistence, as persisting the failed Logout message will increase the sequence for the next login, which will, in turn, cause Resend/Reset after the next Logon.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>
pcicman
When the remote closes the socket during a running session, the following kicks in (
FixSession):This will trigger session logout, which in turn will attempt to send Logout through the closed connection and fails with:
error: unexpected state - transport failed? = WaitingLogoutConfirm : Error: unexpected state - transport failed? = WaitingLogoutConfirm.Should not this state transition (after socket close) instead prevent sending any further messages and terminate instead so the session can be recovered and reconnected?
This also causes problems with message persistence, as persisting the failed Logout message will increase the sequence for the next login, which will, in turn, cause Resend/Reset after the next Logon.