search

TimelordUK / node-sqlserver-v8

branched from node-sqlserver, SQL server driver compatible with all versions of Node
Other
139 stars 43 forks source link

TypeError: cb is not a function #240

Closed miquik closed 2 years ago

miquik commented 2 years ago

Hello everybody, in lib/pool.js around line 456, in case of catch you call cb(e, null) but you should check if "cb" is not null: if (cb) { cb(e, null) } isn't it?

TimelordUK commented 2 years ago

Thanks a lot I will fix this.

On Wed, 16 Mar 2022 at 15:59, miquik @.***> wrote:

Hello everybody, in lib/pool.js around line 456, in case of catch you call cb(e, null) but you should check if "cb" is not null: if (cb) { cb(e, null) } isn't it?

— Reply to this email directly, view it on GitHub https://github.com/TimelordUK/node-sqlserver-v8/issues/240, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXWJG7PAZTNEON4AOWPRR3VAIANLANCNFSM5Q4KASMQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

TimelordUK commented 2 years ago

Should now be fixed thanks

TimelordUK commented 2 years ago

closing- fixed