search

TimelordUK / node-sqlserver-v8

branched from node-sqlserver, SQL server driver compatible with all versions of Node
Other
135 stars 43 forks source link

Missing binaries for Electron v28 and v29 #324

Closed rbolink closed 3 months ago

rbolink commented 3 months ago

I'm building an Electron app (v29.3.1) using the Electron builder package. However, when doing this I'm getting the following error:

afbeelding

It seems like binaries for Electron v28 and v29 are missing when looking at the releases. Will these be added anytime soon?

TimelordUK commented 3 months ago

v28 does not compile and that wont be looked at any time soon - v29, v30 both seem to compile I will release binaries for these shortly in coming day or so

rbolink commented 3 months ago

@TimelordUK I saw that you released v4.2.0 of the package. However, when looking at the files that belong to this tag it seems like the new changes are not included. The package.json also contains version: 4.1.2 instead of version: 4.2.0. Did something go wrong during the release or am I just too impatient?

TimelordUK commented 3 months ago

I’ll check tonight. The binaries should be attached to the release the tar gz. I have not released anything to npm presently.

TimelordUK commented 3 months ago

i recreated release, i will push to npm in a day or so - v29,v30 should be working on this release

rbolink commented 3 months ago

@TimelordUK Thanks! Will close this issue if the release is working

rbolink commented 3 months ago

@TimelordUK It all seems to work, so I'm closing the issue. Thanks for adding the binaries on this short term!