Add support for ::std::net types like sockets and IP addresses

TimelyDataflow / abomonation

A mortifying serialization library for Rust

MIT License

322 stars 30 forks source link

Add support for ::std::net types like sockets and IP addresses #13

Closed antiguru closed 5 years ago

antiguru commented 5 years ago

Add support for types encoding IPv4/6 addresses and their corresponding sockets.

Signed-off-by: Moritz Hoffmann antiguru@gmail.com

frankmcsherry commented 5 years ago

Because I don't know enough about these: do we have confidence that these types have no heap allocations on all platforms? They seem like wrappers around platform-specific types, which are harder to reason about with confidence.

antiguru commented 5 years ago

It seems to be a pointer-free data structure on Linux, Mac, and Windows:

https://msdn.microsoft.com/en-us/library/windows/desktop/ms738560(v=vs.85).aspx
http://man7.org/linux/man-pages/man7/ipv6.7.html
https://opensource.apple.com/source/xnu/xnu-201/bsd/netinet6/in6.h

frankmcsherry commented 5 years ago

This looks good to me, with the caveat that we can never really know what is going on behind the scenes.