TimelyDataflow / abomonation

A mortifying serialization library for Rust
MIT License
317 stars 30 forks source link

Implement Abomonation for PathBuf #41

Closed jwoudenberg closed 2 years ago

jwoudenberg commented 2 years ago

This is a flawed implementation of the Abomonation trait for the PathBuf type from the standard library. I'd love some feedback on whether you'd be open to merge an improved implementation (some thoughts below).

The motivation for this: I'm trying out differential-dataflow (amazing library!) for a code analysis tool and have a bunch of filesystem paths that I'd like to send through a dataflow graph.

The flaw in the implementation in this PR (that I'm aware of, there might be others): it uses a unix-specific function and so will cause compilation failures on non-unix platforms. Some options I see:

Would this PR be acceptable with one of the changes above? I can also imagine there's entirely different problems that I'm not aware of!

jwoudenberg commented 2 years ago

I'm switching to using --bincode, so don't need this anymore!