search

TimelyDataflow / differential-dataflow

An implementation of differential dataflow using timely dataflow on Rust.
MIT License
2.54k stars 183 forks source link

Spine drop batches once logical and physical compaction frontiers are empty #399

Closed antiguru closed 8 months ago

antiguru commented 1 year ago

Once the ~physical~ logical compaction frontier is empty, there are no times that can be represented in a a trace, which means that we're good to drop all contents.

This fixes #398.

frankmcsherry commented 1 year ago

I don't think this is right. Physical compaction can be allowed up through [] and it just means that you are only allowed to ask for a cursor through [], not that the trace is invalidated. Logical compaction would be the thing that when it reaches [] would mean that the trace is not obliged to be correct for any time (as none are in advance of / beyond []).

antiguru commented 8 months ago

Closing because this approach is not correct.