I'm not sure about this. It's a gross change as it pulls behavior across
unrelated places, but I'm also not sure how to implement without
effectively duplicating the MergerChunk. What might work is a trait that
extends MergerChunk and just adds the cmp_without_diff function.
The main purpose for this to exist is so that I can use ConsolidateLayout with other regions than the single implementation, otherwise its impossible to have a more specific implementation, for example to support different kinds of regions.
antiguru
commented
2 weeks ago
I'm not sure about this. It's a gross change as it pulls behavior across unrelated places, but I'm also not sure how to implement without effectively duplicating the
MergerChunk. What might work is a trait that extendsMergerChunkand just adds thecmp_without_difffunction.The main purpose for this to exist is so that I can use
ConsolidateLayoutwith other regions than the single implementation, otherwise its impossible to have a more specific implementation, for example to support different kinds of regions.Signed-off-by: Moritz Hoffmann antiguru@gmail.com