TimelyDataflow / timely-dataflow

A modular implementation of timely dataflow in Rust
MIT License
3.3k stars 272 forks source link

Inline give for Buffer #511

Closed antiguru closed 1 year ago

antiguru commented 1 year ago

This fixes a regression introduced by #426 where BufferCore::give now lacked the inline annotation. In pingpong, this changes the runtime as follows:

Without inline:

target/release/examples/pingpong 1 500000000 -w1  2.45s user 0.00s system 99% cpu 2.446 total

With inline:

target/release/examples/pingpong 1 500000000 -w1  1.75s user 0.00s system 99% cpu 1.755 total
frankmcsherry commented 1 year ago

Looks great and thanks!