search

Timendus / ticalc-usb

A library to communicate with TI graphing calculators through WebUSB
https://ticalc.link
GNU General Public License v3.0
29 stars 4 forks source link

Fix splitting of large virtual packets #24

Closed commandblockguy closed 3 years ago

commandblockguy commented 3 years ago

Virtual packets with a size approximately equal to or larger than the device's raw packet buffer size currently are not being handled properly. The virtual packet header's size is set to the number of bytes in the first raw packet, rather than the total number of bytes in the virtual packet, and the raw packet exceeds the maximum buffer size as the size of the raw packet header is not included. This PR fixes this by generating the virtual packet first, before splitting it into chunks to be put into raw packets.

Timendus commented 3 years ago

@commandblockguy Thanks for your amazing work debugging these issues! I always find it really impressive when people manage to not only understand my code, but find issues in them that I couldn't see myself. Mad respect.

Both PRs look good and the tests are green. I'll merge them first and them fix the automated tests.