Timendus / ticalc-usb

A library to communicate with TI graphing calculators through WebUSB
https://ticalc.link
GNU General Public License v3.0
29 stars 4 forks source link

Fix special var names #37

Open Timendus opened 3 years ago

Timendus commented 3 years ago

Closes #32

This should hopefully be a fix for the issues with sending variables with special characters in their names. Probably needs a bit more testing, but this at least fixes sending programs with a θ in their name for me.

If anyone is in the mood to give this a test themselves, that would be much appreciated. Otherwise I'll test it some more and see if I run into any more issues myself.

A question that I had while doing this: what encoding does the "comment" field in a TI file use?

TODO

adriweb commented 3 years ago

The comment field isn't exposed by TI to the user AFAIK so I guess you can just use normal ASCII. But regardless, it's 42 free bytes, they could be anything!

Timendus commented 2 years ago

This PR probably still has a bug. Programs with special characters in their name can't be deleted normally from the calculator.