search

TimesysGit / vigiles-buildroot

Vulnerability management tool that provides Buildroot SBOM generation and CVE Analysis of target images.
https://www.timesys.com/vigiles/
10 stars 3 forks source link

feat: can return error on missing hashfiles or Config.in #7

Closed Minipada closed 3 months ago

Minipada commented 4 months ago

Hi,

We would like to run Vigiles in CI and return an error code when missing Config.in or hashfiles. It is not part of Vigiles itself and more something related to Buildroot but since we want to do a proper scan and the python Vigiles already scanned the package, I thought it would be relevant.

With this change, one can pass directly in the python script arguments to throw an error when missing a hashfile and/or a Config.in. I also added 2 buildroot options which disable this option by default, which does not change the current behaviour.

I have tested this change and the make command returns an error as expected. What do you think? Thanks

harish-bansal commented 4 months ago

@Minipada thanks for this PR.

We are in the process of reviewing this pull request and let you know if any information is needed.

Minipada commented 3 months ago

Hi @harish-bansal , any news on this?

harish-bansal commented 3 months ago

Hi @harish-bansal , any news on this?

Your pull request has been reviewed and will be included in the next Vigiles-Buildroot release.

Minipada commented 3 months ago

Are you going to take this PR, should I bother fixing conflicts?

harish-bansal commented 3 months ago

Are you going to take this PR, should I bother fixing conflicts?

No worries! I've merged your commit to our internal staging used by QA folks for release testing. After testing, the updates will be pushed to the master branch of the GitHub repository.

harish-bansal commented 3 months ago

Hello @Minipada

Your commit https://github.com/TimesysGit/vigiles-buildroot/commit/9133eee9b3659731e98e2b88372c9ef5bd2be51e has been merged into the master. Please close this PR.

Minipada commented 3 months ago

Excellent, thanks!