Prevent empty localName in advertisement.

Timeular / noble-mac

Noble MacOS bindings using the official CoreBluetooth API

MIT License

94 stars 34 forks source link

Prevent empty localName in advertisement. #17

Closed gpgabriel closed 5 years ago

gpgabriel commented 5 years ago

The current PR prevents emitting an empty localName.

I'm not familiar with Objective-C, please raise any possible issues.

geovie commented 5 years ago

LGTM, nice job! Could you also wrap the other advertisement properties (txPowerLevel, manufacturerData, serviceData and serviceUuids) with a std::pair<T, bool>, thanks!

gpgabriel commented 5 years ago

Thanks for the review! I pushed the requested changes.

geovie commented 5 years ago

Great thank you!