Timmeey86 / CustomTrainingStatisticsPlugin

GNU General Public License v3.0
2 stars 1 forks source link

Suspended - Feature: notifications #40

Open maggaou opened 2 years ago

maggaou commented 2 years ago

While in custom training, display pop up notifications from

In later future when necessary features, display pop up notifications from

These notifications could be one time meaning that same number gets only one notification. Second notification for the same number could be different (like "nice!" or "good job!").

Notifications should not appear before taking at least 50 shots (unless the shot has all time best data in which case all time best notifications can appear at any time).

The pop notification, if possible, could be animated with fade in, fade out. Also some kind smiley would be awesome.

Timmeey86 commented 2 years ago

Thanks for the feature idea! Note to future self: We could use https://bakkesmodwiki.github.io/code_snippets/toasts/ for this

maggaou commented 2 years ago

Toasts seems ok. I just ask this to make sure (I'm just a gamer, not coder): can the position be changed? I personally place stats to top right.

Timmeey86 commented 2 years ago

Unfortunately it can't, so I'm gonna have to implement my own toasts

Another note to myself (you don't have to read that, I post it here so I can find that information quickly when I need it): ImGuiWindowFlags_NoDecoration | ImGuiWindowFlags_AlwaysAutoResize | ImGuiWindowFlags_NoSavedSettings | ImGuiWindowFlags_NoFocusOnAppearing | ImGuiWindowFlags_NoMove

Timmeey86 commented 2 years ago

I've been trying to implement this, however the currently available ways for drawing notifications are too limited for implementing this properly. I'm afraid I will have to delay this feature to the point where Bakkesmod upgrades to a newer UI technology which might however never happen

maggaou commented 2 years ago

Ok. Can you explain why the current notification implementation in RLTrainingTimer is not sufficient?