search

Timmeey86 / CustomTrainingStatisticsPlugin

GNU General Public License v3.0
2 stars 1 forks source link

Bug: longest miss streak difference displayed wrong #46

Closed maggaou closed 2 years ago

maggaou commented 2 years ago

I haven't used the plugin much so I don't know if the issue is persistent.

Session one: my longest miss streak is 7 Session two: my longest miss streak is 4. Issue: difference to session one is displayed as +3 but it should be -3.

Timmeey86 commented 2 years ago

This is actually half-way intentional. It basically means "3 better than the last run", and in this case, lower is better.

I know it can be confusing, but it's supposed to be +/green = good, -/red = bad, that way colorblind people will have the +/- as a fallback to see quickly whether they improved or not

maggaou commented 2 years ago

I personally would prefer green minus sign even after reading your answer. But I will gladly respect the author's design view.

I appreciate all your time you have put into this fantastic plugin.

Timmeey86 commented 2 years ago

I appreciate your feedback. I will close this issue, but don't hesitate reporting anything else which seems off for you