search

Timmeey86 / CustomTrainingStatisticsPlugin

GNU General Public License v3.0
2 stars 1 forks source link

Feature: more control what happens when unchecking "enable plugin" #49

Closed maggaou closed 2 years ago

maggaou commented 2 years ago

Currently unchecking "enable plugin" just hides everything but the stats are still recorded. Maybe have the following actions: pause and hide? Pausing should just stop recording and keep graphics visible. Hiding keeps recording on but hides graphics.

Pausing should be temporary if notifications cannot be used, because otherwise one can accidentally play and assume that stats are recorded. But maybe there is also need to permanent pause because sometimes I don't want to overwrite my last session.

If performance isn't much impacted, then maybe display always something on the screen when recording is on. And when recording is off, then nothing is displayed. Some users may want to hide stats and view them later, but in that case some small icon should be displayed to indicate that the plugin is still active.

Timmeey86 commented 2 years ago

I should be able to do this easily after finishing #38

Timmeey86 commented 2 years ago

@maggaou Would this be suitable? grafik

Timmeey86 commented 2 years ago

Options would be like so: grafik

maggaou commented 2 years ago

@maggaou Would this be suitable? grafik

Yes it is very nice.

I'm not sure if implemented yet, but tracking everything in the background is a new feature in sense that if I set

customtrainingstatistics_display_max_goal_speed 0 (etc) Then max goal speed is not tracked. I think background tracking should include everything regardless display options. What may be useful is to select to hide different stats in the summary panel. This way I can avoid copying things that I don't want.

Timmeey86 commented 2 years ago

Right now you can only decide between recording or not recording all stats, and displaying or not displaying the stats you selected. I feel like most people would actually want to record stats which are currently not displayed, so they can display them at the end of the training session, but not during the session. About the summary panel, it will display exactly the stats that you are currently displaying in the overlay. So when you change these settings, the summary panel automatically adapts