TimoHeiten / zer0mqXt

type safe zeroMQ patterns with dotnet core and C#
MIT License
0 stars 0 forks source link

Added .ConfigureAwait(false) to every await call #48

Closed Leoltron closed 3 years ago

Leoltron commented 3 years ago

Just started playing with Roslyn, made a rewriter that adds .ConfigureAwait(false) (or changes it into true in some classes/methods, if you ask nicely) to every await expression without one and found your issue https://github.com/TimoHeiten/zer0mqXt/issues/30 that asks exactly for that, so I ran it on your core project and commited the results. Hope it didnt miss anything.

Flash0ver commented 3 years ago

Cool - thank you very much for your contribution! LGTM - I give the "main-tainer" also a chance to have a look at it as well.

I am a bit of a sucker for everything about Roslyn - would you mind sharing your project with us - I would love to have a look at it.

TimoHeiten commented 3 years ago

ConfigureAwait was implemented.