search

TimoVesalainen / Nintenlord-UPS-patcher

UPS patcher creator and applier.
9 stars 1 forks source link

better performance for "get patch data" #1

Open rehdi93 opened 1 year ago

rehdi93 commented 1 year ago

hello, I was using your tool and I noticed that the "get patch data" is very slow, like 10+seconds to execute.

I looked into it and found a way to make it execute much faster, if you disable WordWrap on the textbox it cuts the execution time by A LOT.

I can make a pull request with these changes, if you want.

TimoVesalainen commented 1 year ago

That sounds odd, it's always been instantaneous to me, even when I just tested it. What kind of patches are you using? I'd like to investigate this myself a bit.

rehdi93 commented 1 year ago

the patch is Pokémon Emerald Rogue, pokeemeraldrogue_EX_1.3.2a.ups

in my testing, assigning the text to the text box is what takes forever.

TimoVesalainen commented 1 year ago

Yeeah, you were right. Did couple of other improvements at the same time. Never tested the app with patches this huge.

TimoVesalainen commented 1 year ago

Fixed in the new release: https://github.com/TimoVesalainen/Nintenlord-UPS-patcher/releases/tag/release%2F1.4