TimothyClaeys / pycose

A Python implementation of the COSE specification (CBOR Object Signing and Encryption) described in RFC 8152.
https://tools.ietf.org/html/rfc8152
Other
39 stars 24 forks source link

Revert "Remove `attrs` package dependency" #108

Closed letmaik closed 1 year ago

letmaik commented 1 year ago

Reverts TimothyClaeys/pycose#104

It turns out this package is used after all, in pycose/messages/context.py using import attr. I didn't notice this earlier as I was looking for attrs (plural). Apparently the attrs package contains both attrs and attr top-level packages.

This was passing CI because the package was pulled in via a test dependency. We should extend CI to do an import test without any further dependencies to catch those issues.