TimothyLKM / pe

0 stars 0 forks source link

Can modify medication list to contain 2 of the same medication #1

Open TimothyLKM opened 7 months ago

TimothyLKM commented 7 months ago

The medication manager does not allow user to add 2 items with the same name. However, when i modify item 2 to be same name as item 1, the program is okay with it.

Screenshot 2024-04-19 at 4.51.31 PM.png

nus-se-script commented 6 months ago

Team's Response

Thank you for finding this flaw. Indeed, the medicine name should not be able to be modified to a name that is existing.

This issue has been marked as a duplicate of #1338 as they both mention the same issue of modifying the medication name to one that exists already.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Medicine can be modified to the same information

image.png When adding medicine, the same medicine is not allowed to be added more than one time. However, the medicine can be modified to the same name without any warnings.

image.png Actually all information can be modified to the same.


[original: nus-cs2113-AY2324S2/pe-interim#1194] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for finding this flaw. Indeed, the medicine name should not be able to be modified to a name that is existing.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]