search

TimothyLKM / pe

0 stars 0 forks source link

File saving/loading do not accommodate identical items. #2

Open TimothyLKM opened 5 months ago

TimothyLKM commented 5 months ago

if my list contains identical items, after exiting and opening the program, all my identical items are gone.

Screenshot 2024-04-19 at 5.05.43 PM.png

nus-pe-bot commented 5 months ago

Team's Response

Thank you for finding this flaw. Indeed, the medicine name should not be able to be modified to a name that is existing.

This issue has been marked as a duplicate of #1338 as they both mention the same issue of modifying the medication name to one that exists already.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Medicine can be modified to the same information

image.png When adding medicine, the same medicine is not allowed to be added more than one time. However, the medicine can be modified to the same name without any warnings.

image.png Actually all information can be modified to the same.

[original: nus-cs2113-AY2324S2/pe-interim#1194] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for finding this flaw. Indeed, the medicine name should not be able to be modified to a name that is existing.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: This should not be a duplicate issue because this deals with the saving and loading of files. If the file saving and loading allows duplicate items to be saved or loading of duplicate items, there should be more error checks when saving and loading.