TimothyLuke / GSE-Advanced-Macro-Compiler

GSE is an alternative advanced macro editor and engine for World of Warcraft.
https://discord.gg/gseunited
MIT License
210 stars 72 forks source link

[BUG] Compatability with BindPad since Nov 15 patch #1225

Closed MechaZao closed 1 year ago

MechaZao commented 1 year ago

šŸ”µ Describe the bug: For years I have always used BindPad as my little "hidden window" of various keybinds and macros, including my GSE macros (keeps the distracting cycling macro off my action bars)

After Tuesday, my GSE Macros no longer fire when bound inside BindPad. They work as expected when placed on an action bar with the same keybind.

šŸ”µ To reproduce: (Steps to reproduce the behavior)

  1. Drag the GSE Macro to BindPad and set a keybind
  2. Attempt to use the keybind (as has been possible for years)
  3. Nothing happens, no errors, nothing.
  4. When the same macro is used on my ElvUI action bar with the same keybind, it works normally.

šŸ”µ Screenshots: image Screenshot of my BindPad window, showing the GSE macro in top left with keybind "7" (no changes here)

šŸ”µ Expected behavior: I would expect it to function as it always has, with Bindpad acting as a hidden action bar for me to store more keybinds on.

šŸ”µ GSE.lua file: GSE.lua.txt Macro in question is BEASTMASTERY_ and it's chained macros BMST and BMAOE though the issue applies to all my characters

šŸ”µ Desktop (please complete the following information):

šŸ”µ GSE Version:

šŸ”µ Additional context: I recognize that this may be an issue with BindPad or WoW itself, but seeing that both addons are updated for 10.0 and neither are throwing any actual errors, I just wanted to bring it to your attention in case there was anything that you (or I) could do.

in the meantime I will just run my macros on my action bar until a hopeful fix :D

TimothyLuke commented 1 year ago

This all changed again with 10.0.2. The /click command needs further information. This is from GSEā€™s end but the same principles are needed at that end. https://github.com/TimothyLuke/GSE-Advanced-Macro-Compiler/wiki/Chaining-Macros

You need to configure GSE to match what Bindpad needs ā€” https://github.com/TimothyLuke/GSE-Advanced-Macro-Compiler/wiki/ActionButtonKeyDown-or-ActionButtonKeyUp-and-Why-this-matters---Macro-Cycling-not-firing

At the minimum the macro stubs will need to be updated if you are using a KeyDown

MechaZao commented 1 year ago

I've already updated stubs and the chained click commands per your troubleshooting options and steps (I did check the discord before posting! lol)

I have keydown forced on as well.

Do you mean that BindPad may not work with keydown?

TimothyLuke commented 1 year ago

Yes - you may need to figure out what BindPad expects and configure GSE to match it.

On Wed, 16 Nov 2022 at 10:37 pm, MechaZao @.***> wrote:

I've already updated stubs and the chained click commands per your troubleshooting options and step (I did check the discord before posting! lol)

I have keydown forced on as well.

Do you mean that BindPad may not work with keydown?

ā€” Reply to this email directly, view it on GitHub https://github.com/TimothyLuke/GSE-Advanced-Macro-Compiler/issues/1225#issuecomment-1316906547, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEMCFOVBPRMIVAX3DME36DWITE7ZANCNFSM6AAAAAASCEA4OE . You are receiving this because you commented.Message ID: @.*** com>

--

*Timothy MinahanM 0406 413 680 | E **@.***

MechaZao commented 1 year ago

I have spent several hours trying different combinations of settings for the macro and keyup/keydown states, and i cannot seem to make it work in BindPad at all anymore.

I learned that BindPad does need KeyDown on in order to use mounts, consumables, and normal spells/macros - but no matter what, GSE macros won't fire in it.

If I convert the macro to a bindpad macro, like so - image

and press the "test" button, it fires! but it won't fire via keybind. I'm at a loss now, so hopefully you may have some insight (i'm not very code-minded, so I couldn't see anything that may cause a problem in BindPad's lua file.)

otherwise I suppose i can just stop using it for this purpose altogether now. that would be a shame. I wish there was an error!

TimothyLuke commented 1 year ago

That macro stub wont work with KeyDown as you have no [button:1] BEASTMASTERY_ LeftButton t; entry

MechaZao commented 1 year ago

the screenshot was taken in the midst of trying out KeyUp - I apologize for not making that clear. It fires with the 'test' button in both keyup and keydown configurations (with the proper stubs)

TimothyLuke commented 1 year ago

I was hoping that that was "it" - cant blame me for that

TimothyLuke commented 1 year ago

I got this to work. The key is to mutilate the stub macro and set the ActionButtonUseKeyDown=0 setting (KeyUp mode)

Then change one of the parameters to in the macro stub in /macro to

#showtooltip
/click [button:2] IZZI_SP_CRASHSHADOW RightButton; [button:3] IZZI_SP_CRASHSHADOW MiddleButton; [button:4] IZZI_SP_CRASHSHADOW Button4; [nobutton:1] IZZI_SP_CRASHSHADOW; IZZI_SP_CRASHSHADOW

The key was the nobutton mod -- [nobutton:1] IZZI_SP_CRASHSHADOW