TimothyLuke / GSE-Advanced-Macro-Compiler

GSE is an alternative advanced macro editor and engine for World of Warcraft.
https://discord.gg/gseunited
MIT License
216 stars 73 forks source link

[BUG] CREATING A SEQUENCE ( BY RENAMING AN ALREADY EXISTING ONE ) GIVES COMPILE ERROR. #1587

Closed lloskka closed 3 months ago

lloskka commented 3 months ago

πŸ”΅ Describe the bug:

Hey Tim, found minor bug here .

It doesn't get in the way at all, and allows you to use all the functionality of gse.

When you create a sequence ( as title says, by renaming an existing one ), gives compile error ( it gets saved, but gives compile error )

πŸ”΅ To reproduce: (Steps to reproduce the behavior)

  1. Create or have a pair new sequences with these names for example ( fury_single & furyaoe ) ---> important here having underscore bar in the name ---> ****

  2. Mark any of these 2 new sequences created, and rename it just fury

  3. See error printed on chat ( compile error )

πŸ”΅ Screenshots:

WoWScrnShot_080824_181149

πŸ”΅ Expected behavior:

There may be a problem when renaming specifically with underscores and spaces ?!

πŸ”΅ GSE.lua file:

GSE.lua.txt

πŸ”΅ Desktop (please complete the following information):

πŸ”΅ GSE Version:

TimothyLuke commented 3 months ago

You can’t call something just β€œfury” it’s too generic and thee are other things already called fury

TimothyLuke commented 3 months ago

The bug here is you called it fury - what if came from Or the _ is irrelevant. The solution to this is not to try to call this by common wow names like PVP or Arms or Frost etc

lloskka commented 3 months ago

Oh boi, i have been soo wrong these past years?!

So nothing remotely similar in name to whats lets say active or in use.

So much stupidity not even remotely thinking meself THAT. 🀦

Ok! Have a wonderful day.

TimothyLuke commented 3 months ago

It’s a super easy mistake to make and everyone has made it.

TimothyLuke commented 3 months ago

If you called it DJ_Fury of DJ_Fury_ST you would have zero issue it’s only the super common names that other mods or terms blizzard would use.