TimothyLuke / GSE-Advanced-Macro-Compiler

GSE is an alternative advanced macro editor and engine for World of Warcraft.
https://discord.gg/gseunited
MIT License
218 stars 73 forks source link

LUA Error since Update to [3.2.13] #1637

Closed 3xk41 closed 2 months ago

3xk41 commented 2 months ago

🔵 Describe the bug: Since The Update to Version [3.2.13] (2024-09-10) i got Ingame Erros for my Macro: https://wowlazymacros.com/t/orbalisks-by-the-light-pvp-mythic-raid-v-3-9-updated-9-04-24/41420/96

🔵 The error:

360x bad argument #1 to '?' (Usage: local spellInfo = C_Spell.GetSpellInfo(spellIdentifier))
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "@Blizzard_FrameXML/RestrictedFrames.lua"]:674: in function <Blizzard_FrameXML/RestrictedFrames.lua:673>
[string "@Blizzard_FrameXML/RestrictedFrames.lua"]:812: in function `CallMethod'
[string "    local mods = "RALT=" .. tostring(IsRightAltKeyDown()) .. "|" ..
    "LALT=".. tostring(IsLeftAltKeyDown()) .. "|" ..
    "AALT=" .. tostring(IsAltKeyDown()) .. "|" ..
    "RCTRL=" .. tostring(IsRightControlKeyDown()) .. "|" ..
    "LCTRL=" .. tostring(IsLeftControlKeyDown()) .. "|" ..
    "ACTRL=" .. tostring(IsControlKeyDown()) .. "|" ..
    "RSHIFT=" .. tostring(IsRightShiftKeyDown()) .. "|" ..
    "LSHIFT=" .. tostring(IsLeftShiftKeyDown()) .. "|" ..
    "ASHIFT=" .. tostring(IsShiftKeyDown()) .. "|" ..
    "AMOD=" .. tostring(IsModifierKeyDown()) .. "|" ..
    "MOUSEBUTTON=" .. GetMouseButtonClicked()
    self:SetAttribute('localmods', mods)
    local step = self:GetAttribute('step')
    step = tonumber(step)
    if self:GetAttribute('stepped') then
        self:SetAttribute('stepped', false)
    else
        for k,v in pairs(spelllist[step]) do
            if k == "macrotext" then
                self:SetAttribute("macro", nil )
                self:SetAttribute("unit", nil )
            elseif k == "macro" then
                self:SetAttribute("macrotext", nil )
                self:SetAttribute("unit", nil )
            end
            self:SetAttribute(k, v )
        end

        step = step % #spelllist + 1
        self:SetAttribute('stepped', true)
        self:SetAttribute('step', step)
        self:CallMethod('UpdateIcon')
    end
    "]:32: in function <[string "    local mods = "RALT=" .. tostring(IsRigh..."]:1>
[string "=(tail call)"]: ?
[string "=[C]"]: ?
[string "@Blizzard_FrameXML/RestrictedExecution.lua"]:483: in function <...aceBlizzard_FrameXML/RestrictedExecution.lua:446>
[string "=(tail call)"]: ?
[string "@Blizzard_FrameXML/SecureHandlers.lua"]:285: in function <Blizzard_FrameXML/SecureHandlers.lua:279>
[string "=(tail call)"]: ?

Locals:

🔵 Expected behavior: Please Fix the LUA Error or Check if its a Failure of the Script Writer. (then close this ISsue)

🔵 Desktop (please complete the following information):

🔵 GSE Version:

TimothyLuke commented 2 months ago

This isnt a bug - This is a Garbage In - Garbage Out error. That sequence has a lot of rubbish and needs to be rebuilt.

Its trying to use 3.1 variables and broken old repeat blocks which wont work in 3.2. Most likely from when it was part of 3.1

                ["Variables"] = {
                    ["Toys"] = {
                        [1] = "/use [nocombat]  The Heartbreaker",
                        [2] = "/use The Flag of Ownership"
                    },
                    ["Post"] = {
                        [1] = "/cast [nochanneling] Hammer of Wrath"
                    },
                    ["Mods"] = {
                        [1] = "/targetenemy [noharm][dead]",
                        [2] = "/startattack",
                        [3] = "/cast [mod:shift] Rebuke",
                        [4] = "/cast [mod:alt] Hammer of Justice",
                        [5] = "/cast [mod:ctrl,@focus] Hammer of Justice"
                    },
                    ["Toyss"] = {
                        [1] = "/use Lion's Pride Firework",
                        [2] = "/use [nocombat]  Everlasting Alliance Firework"
                    }

It needs to be corrected by the original author.