TimothyLuke / GSE-Advanced-Macro-Compiler

GSE is an alternative advanced macro editor and engine for World of Warcraft.
https://discord.gg/gseunited
MIT License
218 stars 73 forks source link

[BUG] #1689

Closed Juffel-GSE closed 4 weeks ago

Juffel-GSE commented 4 weeks ago

πŸ”΅ Describe the bug: As a Shadow Priest, I find mid fight often my mind flay cast in my sequence just stops casting. This happens when it gets empowered and becomes 'mind flay: insanity' for 1 cast then goes back to being 'mind flay' I think may be the issue. I can see if I look at my macro right after a fight with the issue present ends, it has changed in my sequence to 'mind flay: insanity' and hasnt changed back to Mind Flay so it doesnt cast mind flay any more during that fight it appears. I do find that the next fight it does swap back and can be ok until a longer fight where the issue can happen again.

πŸ”΅ To reproduce: (Steps to reproduce the behavior)

  1. Using a sequence with /cast [nochanneling] mind flay, or variations such as '[known:mind flay] Mind Flay; [nochanneling:Void Torrent, nochanneling:Mind Flay: Insanity] Mind Flay: Insanity' or any variation of that.
  2. Try a dungeon or a delve, after mind flay is empowered to mind flay insanity periodically the sequence will just no longer cast mind flay at all until it becomes mind flay: insanity again for 1 cast. It won't cast regular mind flay once it starts to happen until the fight ends and you start the next fight.

πŸ”΅ The error: No errors given.

πŸ”΅ Screenshots: The top image is how I wrote the macro and how it appears when it is working. The bottom image is what I noticed when I opened my sequence immediately after exiting a fight where the issue occured and noticed it was changed to mind flay: insanity. image

πŸ”΅ Expected behavior: When mind flay is present, cast mind flay. When it is empowered and becomes mind flay: insanity, cast mind flay: insanity. After empowerment ends and the spell reverts to Mind Flay, cast Mind flay.

πŸ”΅ GSE.lua file: Please provide your GSE.lua file or the export string for the specific macro that is causing an issue.

πŸ”΅ Desktop (please complete the following information):

πŸ”΅ GSE Version:

πŸ”΅ Additional context: I think I've provided all I can think of, please let me know if you need more thank you.

TimothyLuke commented 4 weeks ago

The solution is /use [known:391403] Mind Flay: Insanity; Mind Flay

TimothyLuke commented 4 weeks ago

It's a WoW bug, unfortunately, not a GSE bug. GSE asks WoW with casts as opposed to use what is the base spell and sometimes WoW forgets. See #1644 and https://github.com/TimothyLuke/GSE-Advanced-Macro-Compiler/wiki/Base-Spells-and-Translating-Sequences-and-Macro-between-languages.

Juffel-GSE commented 4 weeks ago

The work around is working nicely, thank you for the quick reply!

TimothyLuke commented 4 weeks ago

The spellID is Mind Flay: Insanities spell id - solves the : in the spell name issue with [known: Mind Flay: Insanities]