GSE2 Macro Text Parser dropping certain combinations of macro modifiers.

[andrewkhunn]

I've noticed GSE2 adding spaces and removing some macro information (presumably an issue with parsing on import/save).

ORIGINAL

Sequences['Enmity'] = {
  Author="Enmity",  
  SpecID=251,
  Talents = "2232111",
  Helplink = "http://bit.ly/2j7uiSA",
  Help = "20ms Repeat Rate",
  Default=1,
  PVP=2,
  Icon='Spell_Deathknight_FrostPresence',
  MacroVersions = {
    [1] = {
      StepFunction = "Sequential",
      KeyPress={
        "/cast [combat] Pillar of Frost",
      },
      PreMacro={
      },
        "/cast [talent:7/1,combat] Obliteration",
        "/castsequence reset=combat Howling Blast, Frost Strike, Obliterate, Frost Strike, Obliterate",
        "/castsequence reset=combat [talent:7/3] Glacial Advance, [talent:6/1] Frostscythe, Frost Strike, Frost Strike, [talent:6/1] Frostscythe, [talent:6/1] Frostscythe",
        "/castsequence reset=combat Frost Strike, Obliterate, [talent:6/1] Frostscythe",
        "/cast [talent:7/3,combat] Glacial Advance",
        "/cast [combat] Obliterate",
        "/cast [combat] Frost Strike",
        "/cast [combat] Obliterate",
        "/cast [talent:6/1,combat] Frostscythe",
        "/cast [combat] Empower Rune Weapon",
        "/cast [combat] Remorseless Winter",
      PostMacro={
      },
      KeyRelease={
        "/targetenemy [noharm][dead]",
        "/cast [combat] Anti-Magic Shell",
      },
    },
    [2] = {
      StepFunction = "Sequential",
      KeyPress={
        "/cast [combat] Pillar of Frost",
      },
      PreMacro={
      },
        "/cast reset=60 [talent:4/2,combat] Blinding Sleet",
        "/cast reset=45 [pvptalent:6/3,combat] Chill Streak",
        "/cast [combat] Obliterate",
        "/cast [combat] Frost Strike",
        "/cast [combat] Obliterate",
        "/cast [talent:6/1,combat] Frostscythe",
        "/cast [combat] Empower Rune Weapon",
        "/cast reset=90 [talent:7/1,combat] Obliteration",
        "/castsequence reset=combat Howling Blast, Frost Strike, Obliterate, Frost Strike, Obliterate",
        "/castsequence reset=combat [talent:7/3] Glacial Advance, [talent:6/1] Frostscythe, Frost Strike, Frost Strike, [talent:6/1] Frostscythe, [talent:6/1] Frostscythe",
        "/castsequence reset=combat Frost Strike, Obliterate, [talent:6/1] Frostscythe",
        "/cast [combat] Remorseless Winter",
      PostMacro={
      },
      KeyRelease={
        "/targetenemy [noharm][dead]",
        "/cast [combat] Anti-Magic Shell",
      },
    },
  },
}

AFTER IMPORT

Sequences['Enmity'] = {
  Author="Enmity",  
  SpecID=251,
  Talents = "2232111",
  Helplink = "http://bit.ly/2j7uiSA",
  Help = "20ms Repeat Rate",
  Default=1,
  PVP=2,
  Icon='Spell_Deathknight_FrostPresence',
  MacroVersions = {
    [1] = {
      StepFunction = "Sequential",
      KeyPress={
        "/cast [combat] Pillar of Frost",
      },
      PreMacro={
      },
        "/cast [talent:7/1,combat] Obliteration",
        "/castsequence  reset=combat  Howling Blast, Frost Strike, Obliterate, Frost Strike, Obliterate",
        "/castsequence [talent:7/3] Glacial Advance, [talent:6/1] Frostscythe, Frost Strike, Frost Strike, [talent:6/1] Frostscythe, [talent:6/1] Frostscythe",
        "/castsequence [talent:6/1] Frostscythe",
        "/cast [talent:7/3,combat] Glacial Advance",
        "/cast [combat] Obliterate",
        "/cast [combat] Frost Strike",
        "/cast [combat] Obliterate",
        "/cast [talent:6/1,combat] Frostscythe",
        "/cast [combat] Empower Rune Weapon",
        "/cast [combat] Remorseless Winter",
      PostMacro={
      },
      KeyRelease={
        "/targetenemy  [noharm][dead]",
        "/cast [combat] Anti-Magic Shell",
      },
    },
    [2] = {
      StepFunction = "Sequential",
      KeyPress={
        "/cast [combat] Pillar of Frost",
      },
      PreMacro={
      },
        "/cast reset=60 [talent:4/2,combat] Blinding Sleet",
        "/cast reset=45 [pvptalent:6/3,combat] Chill Streak",
        "/cast [combat] Obliterate",
        "/cast [combat] Frost Strike",
        "/cast [combat] Obliterate",
        "/cast [talent:6/1,combat] Frostscythe",
        "/cast [combat] Empower Rune Weapon",
        "/cast [talent:7/1,combat] Obliteration",
        "/castsequence  reset=combat  Howling Blast, Frost Strike, Obliterate, Frost Strike, Obliterate",
        "/castsequence [talent:7/3] Glacial Advance, [talent:6/1] Frostscythe, Frost Strike, Frost Strike, [talent:6/1] Frostscythe, [talent:6/1] Frostscythe",
        "/castsequence [talent:6/1] Frostscythe",
        "/cast [combat] Remorseless Winter",
      PostMacro={
      },
      KeyRelease={
        "/targetenemy  [noharm][dead]",
        "/cast [combat] Anti-Magic Shell",
      },
    },
  },
}

Added Spaces: Lines 19, 32, 51, and 58 Stripped Content: Lines 20, 21, 50, 52 and 53

Let me know if you need anything else from me to debug this. Thanks!

GSE.lua

[andrewkhunn]

This is NOT fixed in 2.0.6 AFAIK.

[TimothyLuke]

Hi Andrew I just edited you post so I can tell one line from the other. Github deals with code blocks better when you select the block after paste and then hit the <> code button.

[TimothyLuke]

GSE parses what comes in and has to interpret it. It may add an extra space but it also cleans up redundant boilerplate. The adding extra spaces is cosmetic but I will trace it. The loosing of reset=combat is a bug. Its this combination - reset=combat [talent:7/3]

"/castsequence [talent:7/3] Glacial Advance, [talent:6/1] Frostscythe, Frost Strike, Frost Strike, [talent:6/1] Frostscythe, [talent:6/1] Frostscythe", "/castsequence reset=combat [talent:7/3] Glacial Advance, [talent:6/1] Frostscythe, Frost Strike, Frost Strike, [talent:6/1] Frostscythe, [talent:6/1] Frostscythe",

[TimothyLuke]

Hi Andrew

This is complicated to solve. I have just added a UnitTest for this. UnitTests are executed every time I change code for GSE to test that I dont accidently break stuff. The limitations is that I cant UnitTest Macro Execution and I cant UnitTest the GUI. The enxt step will be changing the code unitl the Unit Test returns the right result. Then wow should follow.

[TimothyLuke]

(Im apologising if you get a bunch of spam emails about checkings)

[TimothyLuke]

Unit Tests are passing now. Will be in the 2.0.8 release

[TimothyLuke]

This change actually broke castsequence.

I've reverted it as the syntax should be /castsequence options resetcondition spelllist

"/castsequence reset=combat [talent:7/3] Glacial Advance, [talent:6/1] Frostscythe, Frost Strike, Frost Strike, [talent:6/1] Frostscythe, [talent:6/1] Frostscythe", should be

"/castsequence [talent:7/3] reset=combat Glacial Advance, [talent:6/1] Frostscythe, Frost Strike, Frost Strike, [talent:6/1] Frostscythe, [talent:6/1] Frostscythe",

[andrewkhunn]

Huh, odd. Would that mean that each talent modifier needs it's own reset=combat?

[andrewkhunn]

Sorry for making you do so much unnecessary work, BTW. :(

[TimothyLuke]

I believe so as each modifier is its own castsequence

TimothyLuke

On 17 Jan 2017, at 10:58 am, Andrew Hunn notifications@github.com wrote:

Huh, odd. Would that mean that each talent modifier needs it's own reset=combat?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

[TimothyLuke]

Not at all it forced me to develop unit tests that if I break that area again will warn me before I get a release out.

TimothyLuke

On 17 Jan 2017, at 10:59 am, Andrew Hunn notifications@github.com wrote:

Sorry for making you do so much unnecessary work, BTW. :(

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

[TimothyLuke]

If you look at this area - https://travis-ci.org/TimothyLuke/GnomeSequencer-Enhanced/builds

I cant test everything as its checking what it can that doesnt need WoW to interact with but its able to verify the core of things.

[andrewkhunn]

        "/castsequence reset=combat Howling Blast, Frost Strike, Obliterate, Frost Strike, Obliterate",
        "/castsequence reset=combat [talent:7/3] Glacial Advance, [talent:6/1] Frostscythe, Frost Strike, Frost Strike, [talent:6/1] Frostscythe, [talent:6/1] Frostscythe",
        "/castsequence reset=combat Frost Strike, Obliterate, [talent:6/1] Frostscythe",

To be clear, this block from the 1st macro should become this?

        "/castsequence reset=combat Howling Blast, Frost Strike, Obliterate, Frost Strike, Obliterate",
        "/castsequence [talent:7/3] reset=combat Glacial Advance, [talent:6/1] Frostscythe, Frost Strike, Frost Strike, [talent:6/1] Frostscythe, [talent:6/1] Frostscythe",
        "/castsequence reset=combat Frost Strike, Obliterate, [talent:6/1] Frostscythe",

And that would apply reset=combat to each /castsequence appropriately? I am using this format in 2.0.8 and the parser is scrambling things around. Do i need to wait for 2.0.9?

[TimothyLuke]

yeah need to wait for 2.0.9 - its scrambling things around in 2.0.8

On Tue, Jan 17, 2017 at 11:51 AM, Andrew Hunn notifications@github.com wrote:

    "/castsequence reset=combat Howling Blast, Frost Strike, Obliterate, Frost Strike, Obliterate",
    "/castsequence reset=combat [talent:7/3] Glacial Advance, [talent:6/1] Frostscythe, Frost Strike, Frost Strike, [talent:6/1] Frostscythe, [talent:6/1] Frostscythe",
    "/castsequence reset=combat Frost Strike, Obliterate, [talent:6/1] Frostscythe",

To be clear, this block from the 1st macro should become this?

    "/castsequence reset=combat Howling Blast, Frost Strike, Obliterate, Frost Strike, Obliterate",
    "/castsequence [talent:7/3] reset=combat Glacial Advance, [talent:6/1] Frostscythe, Frost Strike, Frost Strike, [talent:6/1] Frostscythe, [talent:6/1] Frostscythe",
    "/castsequence reset=combat Frost Strike, Obliterate, [talent:6/1] Frostscythe",

And that would apply reset=combat to each /castsequence appropriately? I am using this format in 2.0.8 and the parser is scrambling things around. Do i need to wait for 2.0.9?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/TimothyLuke/GnomeSequencer-Enhanced/issues/201#issuecomment-272998008, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjBFf3ORt09SRPHnIm05jtVtE3DRqZiks5rTBeygaJpZM4LjoK6 .

[andrewkhunn]

Thanks for the quick reply. Any idea when you might push that out?

Might try and get up and running via this git repo if it will be awhile.

[andrewkhunn]

Up and running on 2.0.9 pulled like 2 mins ago and this:

"/castsequence reset=combat Frost Strike, Obliterate, [talent:6/1] Frostscythe",

is getting imported as this:

"/castsequence [talent:6/1] Frostscythe",

Should that line be formatted differently or does an edge case need to be added to the parser?

[TimothyLuke]

its 12pm here - im at work. Will push in about 6 hours after i get home. In the interim Grab the translator.lua file and replace that - it has the correct stuff.

On Tue, Jan 17, 2017 at 12:08 PM, Andrew Hunn notifications@github.com wrote:

Up and running on 2.0.9 pulled like 2 mins ago and this:

"/castsequence reset=combat Frost Strike, Obliterate, [talent:6/1] Frostscythe",

is getting imported as this:

"/castsequence [talent:6/1] Frostscythe",

Should that line be formatted differently or does an edge case need to be added to the parser?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/TimothyLuke/GnomeSequencer-Enhanced/issues/201#issuecomment-272999929, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjBFZtLlQ__TCEeJmM4t0WYb02mdmXMks5rTBuGgaJpZM4LjoK6 .

[andrewkhunn]

Cool, just trying to get up and running. No worries. Just so you're aware though, the last comment is still valid.

"/castsequence reset=combat Frost Strike, Obliterate, [talent:6/1] Frostscythe",

is being imported as:

/castsequence [talent:6/1] Frostscythe

with the latest code in the repo. I assume the parser needs an edge case built into it, or I need to reformat that /castsequence somehow.

[patnodewf]

Moving this over here, from my issue (#213) with hunter pet abilities:

In 2.0.8 the line for /petattack [@target,harm], [@target,harm] is all white text, instead of green - but it still processes the command.