TimothyLuke / GSE-Advanced-Macro-Compiler

GSE is an alternative advanced macro editor and engine for World of Warcraft.
https://discord.gg/gseunited
MIT License
213 stars 73 forks source link

Rogue Sinister Strike being replaced with Roll the Bones #465

Closed petesmisc closed 6 years ago

petesmisc commented 6 years ago

It seems that upon an fresh import, GSE replaces Sinister Strike with Roll the Bones, not all instances of SS but in this case just one. This issue has been seen by other people using this macro but it seems to not break the macro since Roll the Bones is never actually done (very strange)

Macro location: https://wowlazymacros.com/forums/topic/bfa-outlaw-questing-pvp/ its v.4

here is a sample: /castsequence [reset=combat] Sinister Strike, Roll the Bones, Blade Flurry, Sinister Strike, Sinister Strike, Sinister Strike, Pistol Shot, Roll the Bones

The OP never put in "Roll the Bones" in the macro, also, he has the "Slice and Dice" talent, which does not use Roll the Bones.

TimothyLuke commented 6 years ago

Hi Petermsc,

Slice n Dice as a talent replaces Roll the Bones. In a macro however if you go /cast Roll the Bones and you have the talent for SnD, it will cast SnD. If however you put SnD in your macro and you change talents and you no longer have SnD, your macro will hang.

GSE replaces talented abilities like SnD with their base ability. If you see #406 this change is exactly what is expected. It’s not changing Sinister Strike but Slice N Dice.

This is working exactly as it is supposed to.

TimothyLuke

On 1 Sep 2018, at 1:57 am, Petetsmisc notifications@github.com wrote:

It seems that upon an fresh import, GSE replaces Sinister Strike with Roll the Bones, not all instances of SS but in this case just one. This issue has been seen by other people using this macro but it seems to not break the macro since Roll the Bones is never actually done (very strange)

Macro location: https://wowlazymacros.com/forums/topic/bfa-outlaw-questing-pvp/ its v.4

here is a sample: /castsequence [reset=combat] Sinister Strike, Roll the Bones, Blade Flurry, Sinister Strike, Sinister Strike, Sinister Strike, Pistol Shot, Roll the Bones

The OP never put in "Roll the Bones" in the macro, also, he has the "Slice and Dice" talent, which does not use Roll the Bones.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

petesmisc commented 6 years ago

Ok, so in my case, I always had Slice and Dice but when the macro was imported, it showed Roll the Bones. So, are you saying that even though it says Roll the Bones, its actually casting Slice and Dice (I'm talented with Slice and Dice)?

At this point I don't know what the OP of the macro had in there, he swears up and down that he NEVER had Roll the Bones in there, so I just don't know how its showing up in the macro. So, right now I have Slice and Dice talented and if I import the macro, it will show Roll the Bones (don't know if the OP has that in the export or what, trying to work with him to figure out whats going on)

TimothyLuke commented 6 years ago

"Ok, so in my case, I always had Slice and Dice but when the macro was imported, it showed Roll the Bones. So, are you saying that even though it says Roll the Bones, its actually casting Slice and Dice (I'm talented with Slice and Dice)? "

Yes. Even though your macro says roll the bones it casts Slice n Dice as that spell replaced RtB when you have the SnD talent. Its a mechanic that some classes had in Legion. Now all classes have a version of this now. eg Avenging Wrath and Crusade.

On Sat, Sep 1, 2018 at 7:24 AM Petetsmisc notifications@github.com wrote:

Ok, so in my case, I always had Slice and Dice but when the macro was imported, it showed Roll the Bones. So, are you saying that even though it says Roll the Bones, its actually casting Slice and Dice (I'm talented with Slice and Dice)?

At this point I don't know what the OP of the macro had in there, he swears up and down that he NEVER had Roll the Bones in there, so I just don't know how its showing up in the macro. So, right now I have Slice and Dice talented and if I import the macro, it will show Roll the Bones (don't know if the OP has that in the export or what, trying to work with him to figure out whats going on)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/TimothyLuke/GnomeSequencer-Enhanced/issues/465#issuecomment-417798949, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjBFXGatihoVw7ekx_BczahcnFD_vVkks5uWbCfgaJpZM4WVgmK .

--

*Timothy Minahan*M 0406 413 680 | E timothy@minahan.net

petesmisc commented 6 years ago

So I just deleted the macro, did another import (talented with Slice and Dice) and the macro shows Roll the Bones, now, during execution, I never see Roll the Bones, so its not using that spell. And Slice and Dice is being used.

Ok, thank you for the explination, I will post this in that macros thread.