TimothyLuke / GSE-Advanced-Macro-Compiler

GSE is an alternative advanced macro editor and engine for World of Warcraft.
https://discord.gg/gseunited
MIT License
213 stars 73 forks source link

[ENH] Show the current "Action Count" on the Sequence Editor #920

Closed xan2622 closed 3 years ago

xan2622 commented 3 years ago

Is your feature request related to a problem? Please describe. The Github Issue https://github.com/TimothyLuke/GnomeSequencer-Enhanced/issues/901 was a good find and made GSE users aware of this limitation.

Describe the solution you'd like Woud it be possible to add an "action counter" (that would actualize on the fly) at the bottom of the Sequence Editor, to let the GSE user know how many actions are in his/her current version of the macro?

Suggested messages (depending on the macro, on how many actions/loops it features):

Mock-up

Capture d’écran 2021-07-03 114355

TimothyLuke commented 3 years ago

Prob is you don’t know this till you hit Compile Template. It is shown on that screen by scrolling to the last action.

On 3 Jul 2021, at 7:37 pm, xan2622 @.***> wrote:

 Is your feature request related to a problem? Please describe. The Github Issue #901 was a good find and made GSE users aware of this limitation.

Describe the solution you'd like Add an "action counter" (that would actualize on the fly) at the bottom of the Sequence Editor, to let the GSE user know how many actions are in his/her current version of the macro.

Suggested messages (depending on the macro, on how many actions/loops it features):

This version of the macro currently has X actions out of the 255 that are allowed by the Blizzard's macro API. Your macro exceeds the maximum number of authorized actions, reduce the number of actions or loops.. Mock-up

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

TimothyLuke commented 3 years ago

image

xan2622 commented 3 years ago

Would it be possible to add the maximum number of actions? e.g. 22/255 actions (this would tell the GSE user what's the limit)


EDIT: and could you please add a small warning sign ⚠ at the end of the line, if the macro exceeds the limit ? eg:

267/255 actions ⚠ And hovering the sign would show this message in the tooltip:

Your macro exceeds the maximum number of authorized actions, reduce the number of actions or loops..

TimothyLuke commented 3 years ago

It reports that in the error message if you go past it. It’s also potentially different on some client builds. 255 is the guide but until the WoW error triggers somewhere over 254 you don’t know wff hi at the value is necessarily for your client

TimothyLuke

On 3 Jul 2021, at 11:59 pm, xan2622 @.***> wrote:

 Would it be possible to add the maximum number of actions? e.g. 22/255 actions

(this would tell the GSE user what's the limit)

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.