TimothyYe / godns

A dynamic DNS client tool that supports AliDNS, Cloudflare, Google Domains, DNSPod, HE.net & DuckDNS & DreamHost, etc, written in Go.
https://timothyye.github.io/godns/
Apache License 2.0
1.5k stars 220 forks source link

Linode provider duplicates "*" subdomain record #146

Closed drewgingerich closed 2 years ago

drewgingerich commented 2 years ago

Describe the bug
When using the Linode provider with a subdomain named "*", duplicate DNS records are created.

The frequency of this issue
This issue is easy to reproduce.

Your GoDNS configuration

{
  "provider": "Linode",
  "login_token": "<redacted>",
  "domains": [
    {
      "domain_name": "godns.test",
      "sub_domains": ["@", "*", "minecraft"]
    }
  ],
  "ip_url": "https://icanhazip.com/",
  "ip_type": "IPv4",
  "interval": 5,
  "resolver": "8.8.8.8",
  "debug_info": true,
}

Expected behavior
Only one DNS record should be created for the "*" subdomain.

Screenshots

Screen Shot 2022-04-11 at 6 23 45 PM

Additional context
I've already know the source of the problem and wanted to make this issue to track it. It is due to a bug in the Linode API that makes it unable to find a subdomain when it's named "*". I've contacted Linode support and opened a ticket, but it may be a while.

c4lliope commented 2 years ago

@drewgingerich any progress being made? I'm seeing your same issue on my domain.

drewgingerich commented 2 years ago

Hey there! Sadly no change yet :( Linode support has acknowledged that it's a bug and I get an email every month or so saying they're still looking into.

drewgingerich commented 2 years ago

@c4lliope a PR has been merged with a workaround for this issue, so you should stop seeing duplicate wildcard subdomain records in the next release 👍

c4lliope commented 2 years ago

I pulled and remade my binary, glad you could make an easy repair.

drewgingerich commented 2 years ago

Linode closed the ticket I had open regarding this bug. They essentially said that while they are tracking it, it's not a high enough priority to change in the near future. We have a functional workaround in place, so I'm closing this issue.