search

TimothyYe / godns

A dynamic DNS client tool that supports AliDNS, Cloudflare, Google Domains, DNSPod, HE.net & DuckDNS & DreamHost, etc, written in Go.
https://timothyye.github.io/godns/
Apache License 2.0
1.5k stars 221 forks source link

Google Domains support #45

Closed jfritz closed 5 years ago

jfritz commented 5 years ago

CheckSettings() in utils.go doesn't seem to do validation check if service is "Google".

As a result, any google config will return the error at the bottom of the if block, resulting in the "Settings is invalid! please provide supported DNS provider: DNSPod/HE/AliDNS/Cloudflare/GoogleDomain/DuckDNS" error.

Using latest 1.9 release.

My config.json:

{
  "provider": "Google",
  "email": "CENSORED",
  "password": "CENSORED",
  "domains": [{
      "domain_name": "CENSORED.net",
      "sub_domains": ["www","test"]
  }],
  "ip_url": "https://myip.biturl.top",
  "interval": 300,
  "socks5_proxy": ""
}
TimothyYe commented 5 years ago

@jfritz Thanks! It's a bug, I'll fix it.

TimothyYe commented 5 years ago

@jfritz https://github.com/TimothyYe/godns/releases/tag/V1.9.1 Please try the latest version.

jfritz commented 5 years ago

Thanks, this gets my config running.