search

Timothyoung97 / pe

0 stars 0 forks source link

Edit Function issue #4

Open Timothyoung97 opened 2 years ago

Timothyoung97 commented 2 years ago

image.png

image.png

image.png

Attempted to edit the student's details (in specific address) using the below command. Expected output is incorrect. And I did followed the UG by providing at least 1 parameter with 1 valid index

Command entered: edit 1 a/221b Baker Street2

Output: This student already exists in the address book.

======add on======

The same were observed when I provide other parameters such as emails and phones.

===add on===

Using edit 1 n/Me p/12894128,

It seems like the edit can only edit when you change the name together with other fields. But this is weird... what if I just want to change the address without changing the name?

nus-pe-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Editing a student's address, phone, email without name does not work and throws an irrelevant error.

Editing address alone:

image.png

Editing address and name:

image.png

Editing phone alone:

image.png

Editing phone and name:

image.png

Editing email alone:
image.png

Editing email and name:

image.png

Editing a student's address, phone, email requires the name to be edited as well. Makes it inconvenient for the user.

[original: nus-cs2103-AY2122S1/pe-interim#2628] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This is an unintended behaviour as users might want to edit other fields of a student without having to include the name prefix in the command as well. This would only be an occasional hindrance as users are still able to edit any of the four fields of a student successfully - just that the name prefix has to be included in the command.

For instance, if a user wanted to edit the address field of a student named Jason Tan, the following commands may be used:

edit 1 a/221 Baker Street n/a, edit 1 n/Jason Tan

This would update the student's address successfully. Similarly, the other fields of the student can be updated as well by using their respective prefixes.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.Medium] Originally [severity.High]

Reason for disagreement: As a tester, I agree with the change of severity from High to Medium.

However, I would like to comment that as a user (private tutor), if he/she is already very busy with her daily life, how likely will they be spending a period of their time trying to debug and find the valid command format to enter when the one provided is wrong?

Unlikely right? Users might just close the app and wait for a bug fix from the developers.

In my opinion, I think that this is a very dangerous flaw that can cause many frustrations to the users. It could potentially lead to a loss of customer base and result in financial losses. (If the developers intend to sell the app as a product)

However, given that we are all CS students and are still learners in SWE, I accept the team's decision to change the severity.