search

Timshel / vaultwarden

Fork from dani-garcia/vaultwarden to add OpendID support.
GNU Affero General Public License v3.0
76 stars 12 forks source link

[Suggestion] SSO to unlock the vault #41

Closed jonathanmohamed closed 6 days ago

jonathanmohamed commented 6 months ago

Hey, I have been testing your branch for while. Works great!

I was just wondering if you would consider implementing SSO to unlock the vault in the experimental branch.

Timshel commented 6 months ago

Hey

I suppose you are speaking of key connector ? I have no interest in the feature, so It's not planned.

jonathanmohamed commented 6 months ago

Yes key connector, thats unfortunate but I understand.

I can't entice you with a donation?🫣

Regardless, thanks for taking the time to implement the SSO.

Timshel commented 6 months ago

Hey,

I intend to setup some way to receive donation but more for past work appreciation than for new feature (no way to be disappointed ^^).

I can't entice you with a donation?🫣

Kind of you but I doubt it would make financial sense for a single person to try to finance the development ^^ (I did not look in the matter so I have no sense of the scope of the feature).

Will keep the issue open to track interest :).

danielr1996 commented 2 months ago

For anyone interested there is already a feature request in the upstream repo: https://github.com/dani-garcia/vaultwarden/discussions/2583

dlehman83 commented 2 months ago

I am also interested in this.
I thought this is what the SSO_ONLY config option did, but you still need the master password to unlock.

I'm still testing and figuring out what all the options are and what would be best for my user base.

Thanks for all your work on this.

Timshel commented 6 days ago

Updating here too since I was asked in the OIDCWarden project.

Thx to @danielr1996 mentioning the issue in the Vaultwarden repo where the latest comment highlight the issue with the license of the connector. Since it's part of Bitwarden license agreement it can't really be used without a license, cf:

2.1 Commercial Module License. Subject to Your compliance with this Agreement, Bitwarden hereby grants to You a limited, non-exclusive, non-transferable, royalty-free license to use the Commercial Modules for the sole purposes of internal development and internal testing, and only in a non-production environment.

So I'll be closing this.