Timtech4u / gwtquery

Automatically exported from code.google.com/p/gwtquery
MIT License
0 stars 0 forks source link

IFrameWithDocTypeLinker is not @Shardable #159

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?

1. Write a custom linker which is @Shardable and 
@LinkerOrder(LinkerOrder.Order.POST) and does not override the link(TreeLogger 
logger, LinkerContext context, ArtifactSet artifacts) like expected by the 
sharding API.

2. Run the GWT compilation

What is the expected output? What do you see instead?

The custom link(TreeLogger logger, LinkerContext context, ArtifactSet 
artifacts, boolean onePermutation) which is expected to be called since our 
linker is shardable is actually not called.

This is explained by the com.google.gwt.query.linker.IFrameWithDocTypeLinker 
linker which has not been updated with the sharding API.

To update, you'd simply need to add @Shardable annotation on it (like the 
default com.google.gwt.core.linker.IFrameLinker it overrides does).

What version of the product are you using? On what operating system?

GwtQuery 1.2.0

Please provide any additional information below.

The mgwt appcache linker is a very good sample of a not gwtquery-compatible 
linker : 
http://code.google.com/p/mgwt/source/browse/src/main/java/com/googlecode/mgwt/li
nker/linker/PermutationMapLinker.java

Original issue reported on code.google.com by gael.laz...@gmail.com on 26 Nov 2012 at 1:49

GoogleCodeExporter commented 9 years ago
This issue was closed by revision 9241cc97423e.

Original comment by manuel.carrasco.m on 10 Dec 2012 at 7:49

GoogleCodeExporter commented 9 years ago
Thanks for contributing.

Original comment by manuel.carrasco.m on 10 Dec 2012 at 7:51

GoogleCodeExporter commented 9 years ago

Original comment by manuel.carrasco.m on 10 Dec 2012 at 7:53

GoogleCodeExporter commented 9 years ago
Thank you very much for this amazing toolkit !

Original comment by gael.laz...@gmail.com on 10 Dec 2012 at 8:41