Timtech4u / gwtquery

Automatically exported from code.google.com/p/gwtquery
MIT License
0 stars 0 forks source link

cannot compile from source using instructions given in wiki page #171

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. when doing exactly as given in wiki, unable to build. See attached file for 
logs.

Original issue reported on code.google.com by kisalay...@gmail.com on 14 Jan 2013 at 11:02

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by julien.d...@gmail.com on 16 Jan 2013 at 4:21

GoogleCodeExporter commented 9 years ago
We didnt updated the ContributionFAQ wiki when we migrated the project from 
'svn' to 'git'. 

Could you please follow the new steps and check if they work for you.

Thanks

Original comment by manuel.carrasco.m on 13 Feb 2013 at 4:26

GoogleCodeExporter commented 9 years ago
Not working still (followed the instructions blindly...). Attached what i was 
getting.

Im able to compile using 'mvn clean package -Dmaven.test.skip=true'. 

Original comment by kisalay...@gmail.com on 14 Feb 2013 at 10:08

Attachments:

GoogleCodeExporter commented 9 years ago
For some reason it tries to run the tests when you are saying to maven to skip 
them.

I've just run in my linux and I got the attached output.

Could you give more info about yor environment: SO, maven version etc.

Original comment by manuel.carrasco.m on 14 Feb 2013 at 1:24

Attachments:

GoogleCodeExporter commented 9 years ago
I'm ABLE to compile using 'mvn clean package -Dmaven.test.skip=true'.

The problem is when i'm using instructions in ContributionFAQ (logs attached 
are for that). 
I guess skipping tests is not the right way to compile.

-----------------------------------
I'm using Fedora core 17(3.6.7-4.fc17.x86_64), Apache Maven 3.0.4 
(rNON-CANONICAL_2013-01-22_13-18_mockbuild; 2013-01-22 18:48:29+0530).

Original comment by kisalay...@gmail.com on 14 Feb 2013 at 1:32

Attachments:

GoogleCodeExporter commented 9 years ago
You dont need the tests unless you are going to modify the code so as you are 
sure you dont break anything. We run the tests before committing a new change 
to the repo.

Anyway, as you say the question is why in your machine the tests don't run and 
how to fix it. Actually I dont know what is happening,  the only clue is that 
in your machine the fille 'com/google/gwt/query/Query.gwt.xml' is not in your 
classpath, but it's supposed that it is in the src folder and maven should copy 
it to the target folder before running the tests.

In my computer after running 'maven clean test' I have these files:
$ find . -name "Query.gwt.xml"
./gwtquery-core/src/main/java/com/google/gwt/query/Query.gwt.xml
./gwtquery-core/target/classes/com/google/gwt/query/Query.gwt.xml

What's the output of this command in your machine?

Original comment by manuel.carrasco.m on 14 Feb 2013 at 1:45

GoogleCodeExporter commented 9 years ago
The output is exactly same.

./gwtquery-core/src/main/java/com/google/gwt/query/Query.gwt.xml
./gwtquery-core/target/classes/com/google/gwt/query/Query.gwt.xml

This problem is not hurting me that much, except when i make changes (very few, 
like in issues 170 and 165.). (It might cause a problem for someone else.) 

Original comment by kisalay...@gmail.com on 14 Feb 2013 at 1:53

GoogleCodeExporter commented 9 years ago
It seems a problem in the classpath, but in theory maven should resolve it. 
Maybe if you add the folder with the sources to your classpath you could run 
the tests (i have not tested though). Im using ubuntu with java-sun 1.6.0, 
maybe it is a problem of your java version.

Have you tried other computers? I have tested in a couple of computers with 
linux and mac and the tests run ok.

An alternative is to run them from your IDE. In Eclipse I can right-click on 
the GQueryGwtSuiteTest.java and run as GWT JUnit test. In order to have that 
option in eclipse you have to mark the project as a gwt (properties -> google 
-> Web toolkit -> Use GWT)

BTW, merging patches is easier via github pull-requests since gwtquery is 
duplicated in github, because we can accept the changes with just a click and 
your commit appears in the history of the project.

Original comment by manuel.carrasco.m on 14 Feb 2013 at 3:53

GoogleCodeExporter commented 9 years ago
Thanks for reporting. I've migrated this issue to github : 
https://github.com/gwtquery/gwtquery/issues/202
Please follow the issue there.

Original comment by julien.d...@gmail.com on 15 Jul 2013 at 4:04