Timthreetwelve / WUView

Windows Update Viewer
MIT License
177 stars 12 forks source link

Enhancement - Set by default program to use Windows system language #39

Closed bovirus closed 1 year ago

bovirus commented 1 year ago

Brief summary of your request

Modify installer to use System language

Request details

@Timthreetwelve

I installed the new version where is available my language (italian) but the installer leave unchanged the settings set by previous version (English).

Modify installer/configuration to use by default Windows system language.

For me is teh best settings.

Thanks.

Anything else?

No response

Timthreetwelve commented 1 year ago

@bovirus, I've given this a lot of thought. The issue that you ran into is unique for the case where an existing version that didn't have the desired language was upgraded to a version that now has the desired language. Once the desired language is selected, the settings file is updated, and that language will be used going forward until it is changed again. This should only happen once. Please let me know if it reverts in a subsequent installation.

I could change the default of the UseOSLanguage setting to true and that would cause the app to use the current culture language IF that language has been included in the app. However, this would only be useful for new installations, not updates. See the language selection logic in App.xaml.cs. starting at line 37.

WUView_2023-09-26_17-10-46

The UseOSLanguage setting is the checkbox (in green).

I hope this explains what is happening.

bovirus commented 1 year ago

@Timthreetwelve

I beleieve that enable automatic OS language/application language match (if availble) is a good option.

Of course is suful for each new installation.

bovirus commented 1 year ago

@Timthreetwelve

Thanks.