Timthreetwelve / WUView

Windows Update Viewer
MIT License
177 stars 12 forks source link

Bug Report: app v. 0.5.23.0 - Strings untranslated #46

Closed bovirus closed 1 year ago

bovirus commented 1 year ago

Is there an existing issue for this?

What happened or didn't happen

@Tim

Please run the app. Check screenshot

image

The string "Succeeded" and "Failed" are untranslated.

Steps To Reproduce

No response

Version

0.5.23.0

Windows Version

Windows 11 22H2 64bit italian

Relevant log output

No response

Anything else?

No response

Timthreetwelve commented 1 year ago

@bovirus, the result codes are in English in the enumeration. I had just assumed that since it's part of Microsoft's code it would have been translated to the current culture. If you could supply a translation for the six values in the enum I'll see about writing a method to replace them.

Also, if it's not too much trouble, would you attach a screenshot with an update selected so that the details panel on the bottom is populated?

bovirus commented 1 year ago

@Timthreetwelve

Sure. Done

image

Timthreetwelve commented 1 year ago

Thanks for the screenshot. Even though I can change language in the app, the details (title, description, etc.) are still in English for me.

I've added logic and strings to localize the operation type (Install or Uninstall). There are just two strings:

    <!--  Update Operation Type  -->
    <sys:String x:Key="OperationType_Installation">Installation</sys:String>
    <sys:String x:Key="OperationType_Uninstallation">Uninstallation</sys:String>

Thanks again for your help.

Tim

bovirus commented 1 year ago

@Timthreetwelve

I updated italian translation

https://github.com/Timthreetwelve/WUView/pull/50

Timthreetwelve commented 1 year ago

Thank you.

Timthreetwelve commented 1 year ago

This issue should be resolved as of version 0.5.24.