TimurSivakov / colmaracademy

0 stars 0 forks source link

Colmar Academy (BWS) #1

Open asadmehdi785 opened 6 years ago

asadmehdi785 commented 6 years ago

Rubric Score

Criteria 1: HTML Structure

Criteria 2: Visual Layout for Both Desktop and Mobile Sizes

Criteria 3: Responsive Design (Media Queries, Responsive Units, etc.)

Criteria 4: Visual Design and Accessibility (Color Palette, Typography, Transitions, etc.)

Overall Score: 16/16

Outstanding work with this project! You did an excellent job in all aspects of the project, from keeping your code and project contents organized to implementing the specification. Very well done! I thought the website looked very clean and you definitely put a lot of time and effort making sure the styling for everything was just right, while also keeping it very responsiveness. I also liked how you made use of the alt attribute for your images, well done with that!

You did a good job making use of HTML5 elements such as header, nav, and footer. Consider using other such elements like main, section, and figure as well. Using these kinds of semantic tags can help increase the accessibility of your page and reduce the reliance on div tags.

Additionally, you did a good job placing the video on the webpage as asked in the specification. However, perhaps you might want to try making it autoplay upon loading the page, with the video controls removed. I think that would add a nice touch to your website. Of course, this isn't explicitly specified in the spec, but seeing as how you did a great job following the spec otherwise (while adding your own customizations), it might be something extra that you could try out. It's completely up to you though!

Excellent work overall! I hope you enjoyed the course!

TimurSivakov commented 6 years ago

Hello Asad, thank you for your review. I have a question. When I visit site on mobile phone, there is a horizontal scrollbar (not sure if is called like this) so the size of content is wider then screen size. When I scroll down, it sometimes goes right of left. I don't have it in this project https://timursivakov.github.io/TortoiseshellOptics/ but couldn't find out whats the difference between them. Please, help me to fix it. I suppose, I made a mistake somewhere in the code choosing width. Sorry for my English, I'm not a native speaker.