search

TimvanScherpenzeel / gltf-to-usdz-research

Research and proof of concept of converting glTF to USDZ for AR Quick Look (iOS 12+).
MIT License
188 stars 18 forks source link

Cleanup #5

Closed ox closed 5 years ago

ox commented 5 years ago

I was reading thought the lib and found a bunch of opportunities to clean up the code. Most of these are around removing unnecessary promise chains and indenting, using the stdlib instead of string concat to make paths, and making texture conversion a bit less verbose. I tried to keep in the style of the existing code, and added linter rules to enforce it (I prefer spaces, but eslint will convert to tabs automatically on save).

This PR also fixes issues I was encountering with saving to relative paths.

TimvanScherpenzeel commented 5 years ago

Hi! Thank you for your pull request, I will have a look at it this weekend 👍

TimvanScherpenzeel commented 5 years ago

Thanks @ox, I'll make a few stylistic changes (add prettier) after the merge but in general it looks good 👍

ox commented 5 years ago

Awesome! Thanks for taking a look.